Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding helm chart to the repository #606

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

zer0stars
Copy link

Summary

Adding helm chart for running tableland validator in Kubernetes using helm.

Context

Enabling production setup for running a tableland node.

Implementation overview

Solves the problem of DIMO needing a helm chart to run in k8s.

Implementation details and review orientation

Checklist

  • Are changes backward compatible with existing SDKs, or is there a plan to manage it correctly?
  • Are changes covered by existing tests, or were new tests included?
  • Are code changes optimized for future code readers, commenting on problematic areas to understand (if any)?
  • Future-self question: Did you avoid unjustified/unnecessary complexity to achieve the goal?

sanderpick
sanderpick previously approved these changes Oct 16, 2023
Copy link
Member

@sanderpick sanderpick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice @zer0stars! Thanks for doing this. @brunocalza can you give it a once over as well?

brunocalza
brunocalza previously approved these changes Oct 19, 2023
Copy link
Collaborator

@brunocalza brunocalza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice work @zer0stars ! I was able to deploy a validator using this chart.

In general, this PR looks good to me. I left some comments about changing ports and removing a webhook config.

"EventProcessor": {
"BlockFailedExecutionBackoff": "10s",
"DedupExecutedTxns": true,
"WebhookURL": "https://discord.com/api/webhooks/${VALIDATOR_DISCORD_WEBHOOK_ID}/${VALIDATOR_DISCORD_WEBHOOK_TOKEN}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this config can be removed, this is more like an internal thing we have to notify us when a txn happens (note: it needs to be removed for every chain)

# Https port of the application
httpsPort: 8443
# Metrics port of the application
metricsPort: 8888
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the default validator metrics port is 9090, if you change this to 9090, metrics can be accessed at :9000/metrics

if you change this, there's a change that needs to be made in the readme too

You can specify each parameter using the `--set key=value[,key=value]` argument to `helm install`. For example,

```shell
helm install [release-name] [repo-name]/tableland-validator-node --set imagePullPolicy=Always
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is /tableland-validator-node?

@zer0stars zer0stars dismissed stale reviews from brunocalza and sanderpick via 62ea311 April 25, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants