Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update samples for Python 3.x compatibility #1479

Merged
merged 7 commits into from
Oct 22, 2024

Conversation

bcantoni
Copy link
Contributor

@bcantoni bcantoni commented Sep 28, 2024

These are the only functional issues I've found so far. There are other style/idiom changes but those aren't critical.

This is a draft PR while I do some testing.

Fixes #1469

Copy link

github-actions bot commented Sep 28, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
tableauserverclient
   __init__.py50100% 
   _version.py278163163 41%
   config.py150100% 
   datetime_helpers.py2511 96%
   exponential_backoff.py200100% 
   filesys_helpers.py310100% 
   namespace.py2633 88%
tableauserverclient/helpers
   __init__.py10100% 
   headers.py1388 38%
   logging.py20100% 
   strings.py2711 96%
tableauserverclient/models
   __init__.py410100% 
   column_item.py553232 42%
   connection_credentials.py351111 69%
   connection_item.py771010 87%
   custom_view_item.py1381313 91%
   data_acceleration_report_item.py5411 98%
   data_alert_item.py15933 98%
   data_freshness_policy_item.py1561515 90%
   database_item.py2073636 83%
   datasource_item.py2471111 96%
   dqw_item.py10455 95%
   exceptions.py40100% 
   favorites_item.py5688 86%
   fileupload_item.py190100% 
   flow_item.py1491010 93%
   flow_run_item.py720100% 
   group_item.py8133 96%
   groupset_item.py3911 97%
   interval_item.py1823232 82%
   job_item.py1871010 95%
   linked_tasks_item.py8011 99%
   metric_item.py1301212 91%
   pagination_item.py340100% 
   permissions_item.py1091212 89%
   project_item.py1573333 79%
   property_decorators.py1001818 82%
   reference_item.py2311 96%
   revision_item.py600100% 
   schedule_item.py20666 97%
   server_info_item.py3744 89%
   site_item.py6101212 98%
   subscription_item.py10333 97%
   table_item.py1181818 85%
   tableau_auth.py612424 61%
   tableau_types.py2511 96%
   tag_item.py150100% 
   target.py60100% 
   task_item.py5722 96%
   user_item.py2771717 94%
   view_item.py1791515 92%
   virtual_connection_item.py6488 88%
   webhook_item.py660100% 
   workbook_item.py2751616 94%
tableauserverclient/server
   __init__.py90100% 
   exceptions.py40100% 
   filter.py2111 95%
   pager.py3511 97%
   query.py1431515 90%
   request_factory.py1090148148 86%
   request_options.py24222 99%
   server.py1671717 90%
   sort.py60100% 
tableauserverclient/server/endpoint
   __init__.py330100% 
   auth_endpoint.py761212 84%
   custom_views_endpoint.py1461111 92%
   data_acceleration_report_endpoint.py210100% 
   data_alert_endpoint.py972525 74%
   databases_endpoint.py1103030 73%
   datasources_endpoint.py3113636 88%
   default_permissions_endpoint.py4755 89%
   dqw_endpoint.py431616 63%
   endpoint.py1812020 89%
   exceptions.py6866 91%
   favorites_endpoint.py952222 77%
   fileuploads_endpoint.py510100% 
   flow_runs_endpoint.py651111 83%
   flow_task_endpoint.py2333 87%
   flows_endpoint.py2165858 73%
   groups_endpoint.py1271010 92%
   groupsets_endpoint.py7488 89%
   jobs_endpoint.py711212 83%
   linked_tasks_endpoint.py380100% 
   metadata_endpoint.py881414 84%
   metrics_endpoint.py5888 86%
   permissions_endpoint.py4755 89%
   projects_endpoint.py1532929 81%
   resource_tagger.py1354343 68%
   schedules_endpoint.py1001111 89%
   server_info_endpoint.py361010 72%
   sites_endpoint.py1262828 78%
   subscriptions_endpoint.py581515 74%
   tables_endpoint.py1083636 67%
   tasks_endpoint.py6577 89%
   users_endpoint.py1301616 88%
   views_endpoint.py1381010 93%
   virtual_connections_endpoint.py1151111 90%
   webhooks_endpoint.py571111 81%
   workbooks_endpoint.py3342727 92%
TOTAL10655133088% 

@bcantoni
Copy link
Contributor Author

@jacalata could you please review? Then I will squash and merge.

samples/login.py Show resolved Hide resolved
@bcantoni bcantoni changed the title Draft: Update samples for Python 3.x compatibility Update samples for Python 3.x compatibility Oct 22, 2024
@bcantoni bcantoni merged commit 60dfd4d into development Oct 22, 2024
26 checks passed
@bcantoni bcantoni deleted the bcantoni/1469-update-samples branch October 22, 2024 23:38
jacalata pushed a commit that referenced this pull request Oct 24, 2024
* Feature: export custom views #999 (#1506)
* feat(exceptions): separate failed signin error (#1478)
* refactor request_options, add language param (#1481)
* Set FILESIZE_LIMIT_MB via environment variables (#1466)
* added PulseMetricDefine cap (#1490)
* Adding project permissions handling for databases, tables and virtual connections (#1482)
* fix: queryset support for flowruns (#1460)
* fix: set unknown size to sys.maxsize
* fix: handle 0 item response in querysets (#1501)
* chore: support VizqlDataApiAccess capability (#1504)
* refactor(test): extract error factory to _utils
* chore(typing): flowruns.cancel can also accept a FlowRunItem
* chore: type hint default permissions endpoints (#1493)
* chore(versions): update remaining f-strings (#1477)
* Make urllib3 dependency more flexible (#1468)
* Update requests library for CVE CVE-2024-35195 (#1507)

* chore(versions): Upgrade minimum python version (#1465)
* ci: cache dependencies for faster builds (#1497)
* ci: build on python 3.13 (#1492)
* Update samples for Python 3.x compatibility (#1479)
* chore: remove  py2 holdover code (#1496)
* #Add 'description' to datasource sample code (#1475)
* Remove sample code showing group name encoding (#1486)
* chore(typing): include samples in type checks (#1455)

* fix: docstring on QuerySet
* docs: add docstrings to auth objects and endpoints (#1484)
* docs: docstrings for Server and ServerInfo (#1494)
* docs: docstrings for user item and endpoint (#1485)
* docs: docstrings for site item and endpoint (#1495)
* docs: workbook docstrings (#1488)
* #1464 - docs update for filtering on boolean values (#1471)

---------
Co-authored-by: Brian Cantoni <[email protected]>
Co-authored-by: Jordan Woods <[email protected]>
Co-authored-by: Jordan Woods <[email protected]>
Co-authored-by: Jac <[email protected]>
Co-authored-by: Henning Merklinger <[email protected]>
Co-authored-by: AlbertWangXu <[email protected]>
Co-authored-by: TrimPeachu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants