Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(exceptions): separate failed signin error #1478

Merged
merged 3 commits into from
Oct 10, 2024
Merged

feat(exceptions): separate failed signin error #1478

merged 3 commits into from
Oct 10, 2024
+98 −14

Commits on Sep 28, 2024

  1. feat(exceptions): separate failed signin error 

    Closes tableau#1472

This makes sign in failures their own class of exceptions, while still
inheriting from NotSignedInException to not break backwards
compatability for any existing client code. This should allow users
to get out more specific exceptions more easily on what failed with
their authentication request.
    @jorwoods
    jorwoods committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    c6d74e7 View commit details
    Browse the repository at this point in the history

  2. fix(error): raise exception when ServerInfo.get fails 

    If ServerInfoItem.from_response gets invalid XML, raise the error
immediately instead of suppressing the error and setting an invalid
version number
    @jorwoods
    jorwoods committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    1ec1a5f View commit details
    Browse the repository at this point in the history

  3. fix(test): add missing test asset

    @jorwoods
    jorwoods committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    6eab3c9 View commit details
    Browse the repository at this point in the history