Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1301 duplicate default permission requests #1302

Merged

Conversation

gconklin
Copy link
Contributor

  1. logging to the root logger isn't correct
  2. the log line calls fetch_call() which makes a server request
  3. retuns the results of fetch_call() which is never used anywhere

Removing these lines from _set_default_permissions makes it more functionally equivalent to the above _set_permissions

1. logging to the root logger isn't correct
2. the log line calls fetch_call() which makes a server request
3. retuns the results of fetch_call() which is never used anywhere

Removing these lines from _set_default_permissions makes it more
functionally equivalent to the above _set_permissions
@salesforce-cla
Copy link

Thanks for the contribution! Before we can merge this, we need @gconklin to sign the Salesforce Inc. Contributor License Agreement.

@bcantoni
Copy link
Contributor

@gconklin thanks for the PR! As a first time contributor I had to enable workflows to run here, so we should get the results shortly,

@jacalata
Copy link
Contributor

jacalata commented Jan 4, 2024

Hi @gconklin - last thing needed is a signed CLA. Did you run into any trouble doing that?

@gconklin
Copy link
Contributor Author

gconklin commented Jan 4, 2024

Hi @jacalata - when I go to sign it, it says I've already signed it.
"You already signed the CLA on 2023-10-19"
there's nothing else on the page except a logo of Salesforce cloud logo.

@jacalata jacalata merged commit d79ca4c into tableau:development Jan 6, 2024
18 checks passed
jacalata added a commit that referenced this pull request Jan 13, 2024
#1302 
#1300 
#1330 
#1328 
#1297 
#1307 
#1299 
- fix filename handling in downloads
- fix typing on revisions files
- add typings
- update urllib dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants