Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow node prop values to be selected #103

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

jonaswk
Copy link
Contributor

@jonaswk jonaswk commented Feb 6, 2024

Allow the user to select the values under qg-graph-node-body by introducing a new CSS class qg-prop-value and using it to set the CSS property user-select to all.

This keeps all of the existing behaviour of query graph nodes, i.e. clicking it anywhere to expand/collapse, but still makes it possible to copy out information by right-clicking.

Not being able to do this was a bit of a nuisance sometimes.

Allow the user to select the values under `qg-graph-node-body` by introducing a
new CSS class `qg-prop-value` and using it to set the CSS property `user-select`
to `all`.

This keeps all of the existing behaviour of query graph nodes, i.e. clicking it
anywhere to expand/collapse, but still makes it possible to copy out information
by right-clicking.

Not being able to do this was a bit of a nuisance sometimes.
@vogelsgesang vogelsgesang merged commit c727ee0 into tableau:main Feb 6, 2024
3 checks passed
@jonaswk jonaswk deleted the copyable-prop-values branch February 6, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants