Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(panel/core): add a gamebuild option #975

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

spacevx
Copy link

@spacevx spacevx commented Aug 15, 2024

Someone told me it was pointless to do it because the legacy pages will be rewritten, but I already did it, so I'm sharing it.
It's just an option to change the gamebuild of the FiveM client. I didn't do it for RedM (for now).
If something is wrong, don't hesitate to let me know.

@spacevx spacevx requested a review from tabarra as a code owner August 15, 2024 01:46
@tabarra
Copy link
Owner

tabarra commented Aug 24, 2024

Thanks for the pull request, that was very thorough of you for even including the cfg validator and launch parameter changes.
Unfortunately I cannot merge this PR, at least not for now.
The issue is that txAdmin and fxserver versions are not strictly bound together, which means the list is bound to be wrong eventually, even if we ignore the fact that some people backport tx to older artifacts.

Some time ago I was talking to Cfx about it, and there are plans for them to implement a new native to get the list of all game builds available for the current fxserver version (ref: CFX-738), but there is no ETA for that to be implemented. So for now, this cannot be merged.

I will leave this PR open though, if cfx releases the native before I migrate the settings page, I'll add to it and merge, otherwise will end up closing it.
Thanks again for the contribution, though.

@tabarra tabarra added enhancement New feature or request Pending Changes Pending Changes labels Aug 24, 2024
@spacevx
Copy link
Author

spacevx commented Aug 24, 2024

Hello, I can implement a workaround for this. I just need to find the artifact version based on each game build (Windows/Linux) and compare with the actual artifact. Even if CFX releases a native, it means older server artifacts won’t be compatible since the native will only be available on newer artifacts

@tabarra
Copy link
Owner

tabarra commented Aug 24, 2024

Additional considerations from discord convo:

Not having the feature right now is not stopping anyone from using any game build available, and yet, if I merge the pr, two issues will happen:

  1. If a new DLC becomes available and i'm working on some update, people will want me to release a new txAdmin update just so they can use the new DLC, and even if i'm willing to release said update, then tens of thousand of admins will get a notification to update, but for an update that doesn't add anything meaningful for them.
  2. Or worse, people will see the changelog and the new dlc available, and will try it even if it's not really ready for prime time just yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Pending Changes Pending Changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants