feat: override defaults #1503
Open
feat: override defaults #1503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mvmo
requested review from
juliusmarminge,
nexxeln,
t3dotgg and
c-ehrlich
as code owners
🦋 Changeset detectedLatest commit: 396160d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@Mvmo is attempting to deploy a commit to the t3-oss Team on Vercel. A member of the Team first needs to authorize it. |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://create-t3-app-git-fork-mvmo-feature-override-t3-oss.vercel.app/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1078
✅ Checklist
Changelog
I've implemented a function which is called at the end of the scaffold, which then looks up some default places for configs and if there's a t3stack directory (optionally the config dir can be configured by the T3_CONFIG env var directly), if so it checks if that contains a override/ directory, which then is copied into the just scaffolded project.
On the screenshots i've wrote overwrites but changed it to overrides as a quick google search confirmed, that it's the correct term in this case 😅
Screenshots
Without any config dir nothing changes
When having a t3stack inside the XDG_CONFIG_HOME with a file to overwrite
It uses it to scaffold the project
And it also works with the T3_CONFIG/override
💯