Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: override defaults #1503

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: override defaults #1503

wants to merge 4 commits into from

Conversation

Mvmo
Copy link
Contributor

@Mvmo Mvmo commented Jul 7, 2023

Closes #1078

✅ Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

I've implemented a function which is called at the end of the scaffold, which then looks up some default places for configs and if there's a t3stack directory (optionally the config dir can be configured by the T3_CONFIG env var directly), if so it checks if that contains a override/ directory, which then is copied into the just scaffolded project.

On the screenshots i've wrote overwrites but changed it to overrides as a quick google search confirmed, that it's the correct term in this case 😅


Screenshots

Without any config dir nothing changes

When having a t3stack inside the XDG_CONFIG_HOME with a file to overwrite

It uses it to scaffold the project

And it also works with the T3_CONFIG/override

💯

@changeset-bot
Copy link

changeset-bot bot commented Jul 7, 2023

🦋 Changeset detected

Latest commit: 396160d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-t3-app Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jul 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-t3-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 7, 2023 5:13am

@vercel
Copy link

vercel bot commented Jul 7, 2023

@Mvmo is attempting to deploy a commit to the t3-oss Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 84
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 100
🔴 PWA 30

Lighthouse ran on https://create-t3-app-git-fork-mvmo-feature-override-t3-oss.vercel.app/

@Mvmo Mvmo marked this pull request as draft July 7, 2023 13:51
@Mvmo Mvmo marked this pull request as ready for review September 4, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📌 area: cli Relates to the CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: using custom config files
1 participant