Skip to content

Commit

Permalink
Update TODO
Browse files Browse the repository at this point in the history
  • Loading branch information
szhan committed Jan 15, 2024
1 parent 0f8a4f9 commit b546dc8
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions python/tests/beagle_numba.py
Original file line number Diff line number Diff line change
Expand Up @@ -167,9 +167,8 @@ def get_recombination_rates(cm, h, ne):
# Recombination rate of first site is always 0.
r = np.zeros(len(cm), dtype=np.float32)
r[1:] = np.diff(cm)
# TODO: In the original LS formulation, it's 4 not 0.04. BEAGLE 4.1 uses 0.04.
# It may be related to the choosing mutation rate to be 0.0001.
# This needs to be investigated further.
# TODO: In the original LS formulation, it's 4. BEAGLE 4.1 uses 0.04.
# It may have to do with improving numerical stability.
c = -0.04 * (ne / h)
rho = -1 * np.expm1(c * r)
return rho
Expand Down

0 comments on commit b546dc8

Please sign in to comment.