Add support for collapsible form element container #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dontub
added
enhancement
jensschuppe
requested changes
Aug 9, 2024
There was a problem hiding this comment.
I'd prefer the term collapsible over closeable (which is actually just a variant of closable) and I think the meaning is slightly different. closable refers to something being physically shut or sealed, while collapsible refers to something being folded together. Also, collapsible is what Drupal called this functionality before replacing it with the upstream details element.
dontub
force-pushed
the
closeable-form-element-container
branch
from
3511912
to
a0139ad
Compare
dontub
changed the title
|
It's now collapsible instead of closable. |
jensschuppe
approved these changes
Aug 12, 2024
dontub
added
status:fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to mark a
FormElementContaineras closeable. In a Drupal form it results in adetailselement.systopia-reference: 25909