Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ContactRoles: Don't fail if remote_contact_data.remote_contact_roles is NULL #37

Merged

Conversation

dontub
Copy link
Contributor

@dontub dontub commented May 14, 2024

Because the custom field remote_contact_data.remote_contact_roles is not marked as required, it can not only be an empty array, but also NULL.

systopia-reference: 24946

…` is NULL

Because the custom field `remote_contact_data.remote_contact_roles` is
not marked as required, it can not only be an empty array, but also
`NULL`.
@dontub dontub requested a review from jensschuppe May 14, 2024 09:53
@jensschuppe jensschuppe added bug Something isn't working status:reviewed and tested Code has received thorough review and testing and is ready to be committed/merged. labels May 15, 2024
@jensschuppe jensschuppe merged commit 1aa7f86 into master May 15, 2024
9 checks passed
@jensschuppe jensschuppe deleted the dont-fail-if-remote_contact_data.remote_contact_roles-null branch May 15, 2024 10:11
@jensschuppe jensschuppe added status:fixed The issue has been resolved (usually by committing/merging code). and removed status:reviewed and tested Code has received thorough review and testing and is ready to be committed/merged. labels May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working status:fixed The issue has been resolved (usually by committing/merging code).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants