Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update permission declaration #31

Merged
merged 2 commits into from
Mar 21, 2024
Merged

Update permission declaration #31

merged 2 commits into from
Mar 21, 2024

Conversation

dontub
Copy link
Contributor

@dontub dontub commented Mar 20, 2024

@dontub dontub requested a review from jensschuppe March 20, 2024 14:33
jensschuppe
jensschuppe requested changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@jensschuppe jensschuppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also add descriptions while we're at it.

Also, I'd suggest to re-label the permissions with the correct/official name of the framework:

CiviRemote: Match and link contacts

etc.

@dontub dontub requested a review from jensschuppe March 21, 2024 10:23
@dontub dontub merged commit b480fe4 into master Mar 21, 2024
9 checks passed
@dontub dontub deleted the update-permission-declaration branch March 21, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jensschuppe jensschuppe jensschuppe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dontub @jensschuppe