-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow adding tags to ECK entities #33
base: master
Are you sure you want to change the base?
Conversation
I don't think I agree with this. IMO the permission to view/edit tags on an entity type should be the same as the permission to view/edit entities of that type. So if you have permission to edit an entity of type Foo then you have permission to add tags to it as well. That's how it works with core entities. But I'm not sure per-entity-type permissions have been implemented? I don't see where that's currently happening, and this is just a fixme: de.systopia.eck/Civi/Api4/EckEntity.php Lines 130 to 135 in a4fb482
This happens during every upgrade, so it's not something you have to notify users of. |
You're correct, @colemanw, the extension does not yet define any permissions, but definitely should; see #34. I'd be fine with the Edit Foo Entities permission also controlling access to editing tag assignments on entities of that type for now. But the more granular permissions the better, however 🤓. Adding more granular permissions later will cause larger update routines. Also, I can imagine use cases for not letting creators of entities assign them tags. But let's go with what Core does for now. |
79a5aec
to
fc63ad0
Compare
87fc164
to
f440941
Compare
This will have to be rebased onto #100. |
This needs a rebase now that permissions have been implemented (differently) with #100. I'm also postponing this to after version 1.0. |
This allows adding tags to ECK entities through a tab on the entity's page.
For now, editing tag assignments is allowed for all users allowed to view the tags page (
access CiviCRM
permission), which is, of course, unsafe. There should be dedicated permissions for editing tags on entities for each ECK entity type. This PR is therefore a draft.Also, this requires managed entities be reconciled and the menu router be rebuilt.