Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Afform's automatic custom blocks for custom fields on ECK entity forms #140

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

jensschuppe
Copy link
Collaborator

Fixes #139.

Depends on civicrm/civicrm-core#30239, thus raises Core requirement to 5.75.

This could use a test, I guess …

@jensschuppe jensschuppe added enhancement New feature or request status:needs work There is code, but it needs additional work before it should be reviewed labels Jul 26, 2024
@jensschuppe jensschuppe added this to the 1.1 milestone Jul 26, 2024
@colemanw
Copy link
Collaborator

This looks good to me 👍🏻

@jensschuppe jensschuppe added status:reviewed and tested Code has received thorough review and test and is ready to be committed/merged and removed status:needs work There is code, but it needs additional work before it should be reviewed labels Jul 29, 2024
@jensschuppe jensschuppe merged commit 073e3b5 into master Jul 29, 2024
0 of 10 checks passed
@jensschuppe jensschuppe deleted the customBlocks branch July 29, 2024 07:06
@jensschuppe jensschuppe added status:fixed The issue has been resolved (usually by committing/merging code) and removed status:reviewed and tested Code has received thorough review and test and is ready to be committed/merged labels Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request status:fixed The issue has been resolved (usually by committing/merging code)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deleting a custom field doesn't remove it from the FB form
2 participants