Copy over core functions that are internal & subject to change #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jensschuppe
added
enhancement
jensschuppe
added a commit
that referenced
this pull request
Jul 16, 2024
jensschuppe
added a commit
that referenced
this pull request
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While refactoring some core functions in civicrm/civicrm-core#30671 I noticed that ECK was using one of them. Safest thing to do is copy it over to guard against upstream breakages from civicrm-core updates.
Although in the future I think ECK isn't actually doing much with it and it could probably be refactored out.
Once we're ready to bump the core version of ECK a bit higher....
Until then, this will prevent errors.