Fix redirect htmlized and failing to load on WordPress #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just ran into the same problem with wordpress. This fixes it. Before I encountered this pr I also patched the file in my systems. best Martin |
mattwire
force-pushed
the
fixmultidownload
branch
from
87f5c6a
to
61eebba
Compare
|
@vurt2 Updated patch to update both URLs. @peth-systopia download does not work properly without this patch on WordPress |
jensschuppe
added
bug
|
@mattwire Have you tested this on Drupal as well? |
|
Please ignore my last comment, tested the patch on D10 (with composer now configured) and it works both with and without the patch. Issue was isolated to wordpress and the patch doesn't seem to affect Drupal behaviour. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I only tested this on WordPress but the multiple document download was failing.
The queue was running but then the redirect went to the homepage instead of the download page.
Generated URL:
https://[example.org]/wp-admin/admin.php?page=CiviCRM&q=civicrm%2Fcivioffice%2Fdownload&id=replacedwithhiddenid&instant_download=0&return_url=replacedwithhiddenencodedreturnurlRequired URL:
https://[example.org]/wp-admin/admin.php?page=CiviCRM&q=civicrm%2Fcivioffice%2Fdownload&id=replacedwithhiddenid&instant_download=0&return_url=replacedwithhiddenencodedreturnurl