Add parentheses to lab-02 get pixel macro #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cosmin Popa <[email protected]>
teodutu
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
Legit. Similar to my suggestion form your earlier PR #171, duplicate this change to our new repo [1] so we have it for next year as well.
[1] https://github.com/cs-pub-ro/hardware-software-interface/
c7stef
added a commit
to c7stef/hardware-software-interface
that referenced
this pull request
Mar 11, 2024
This commit adds parentheses around function-like macro parameters. For more details, see systems-cs-pub-ro/iocla#172. Signed-off-by: Cosmin Popa <[email protected]>
3 tasks
teodutu
pushed a commit
to cs-pub-ro/hardware-software-interface
that referenced
this pull request
Mar 19, 2024
This commit adds parentheses around function-like macro parameters. For more details, see systems-cs-pub-ro/iocla#172. Signed-off-by: Cosmin Popa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add parentheses around function-like macro parameters to avoid surprises with operator precedence. For instance:
GET_PIXEL(a, 1<<2, 0).