Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Syntax fix in lab and makefile rule for running compiled program #170

Merged
merged 2 commits into from
Mar 4, 2024
Merged

Syntax fix in lab and makefile rule for running compiled program #170

merged 2 commits into from
Mar 4, 2024

Conversation

c7stef
Copy link
Contributor

@c7stef c7stef commented Mar 4, 2024

  • Added a cast from pointer to int (no implicit conversion)
  • Fixed missing rule for running in generic makefile

teodutu
teodutu approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@teodutu teodutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are OK, but keep in mind that since they target different things they should be made as part of separate PRs. But now you have 2 separate commits and the changes are small, which is fine.

@teodutu teodutu merged commit e6a2a36 into systems-cs-pub-ro:master Mar 4, 2024
1 check failed
@c7stef c7stef deleted the lab-fix branch March 4, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teodutu teodutu teodutu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@c7stef @teodutu