Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dal): Emit audit event when forcing a change set to be created #5229

Merged
merged 1 commit into from
Jan 10, 2025
Merged

fix(dal): Emit audit event when forcing a change set to be created #5229

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/dal/src/change_set.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ use std::time::Duration;
use chrono::{DateTime, Utc};
use serde::{Deserialize, Serialize};
use si_data_pg::{PgError, PgRow};
use si_events::audit_log::AuditLogKind;
use si_events::{ulid::Ulid, WorkspaceSnapshotAddress};
use si_layer_cache::LayerDbError;
use telemetry::prelude::*;
Expand Down Expand Up @@ -786,13 +787,15 @@ impl ChangeSet {
}

/// Returns a new [`ChangeSetId`](ChangeSet) if a new [`ChangeSet`] was created.
/// Also writes an audit log event to head (so we don't have to handle this in every route handler)
pub async fn force_new(ctx: &mut DalContext) -> ChangeSetResult<Option<ChangeSetId>> {
let maybe_fake_pk =
if ctx.change_set_id() == ctx.get_workspace_default_change_set_id().await? {
let change_set = Self::fork_head(ctx, Self::generate_name()).await?;
ctx.update_visibility_and_snapshot_to_visibility(change_set.id)
.await?;

ctx.write_audit_log_to_head(AuditLogKind::CreateChangeSet, change_set.name)
.await?;
WsEvent::change_set_created(ctx, change_set.id)
.await?
.publish_on_commit(ctx)
Expand Down
Loading