Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: BUG-735 consolidate these two events into one place and add the geo assignment #5227

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

jobelenus
Copy link
Contributor

This fix is explicitly for components, since their size is calculated, and not stored 😄

Also, see my note for something to come back to in the future:

note: if a person added a hundred sockets to a component
and that component was a frame, it would not resize itself
and the sockets would appear outside the frame

I tested it:

function main() {
  const asset = new AssetBuilder();

  [...Array(99).keys()].forEach((i) => {
  const outputTest = new SocketDefinitionBuilder()
        .setName("Test" + i)
        .setArity("one")
        .setConnectionAnnotation("Test<string>")
        .build();
    asset.addOutputSocket(outputTest);
  })
  
  return asset.build();
}
image

@jobelenus jobelenus requested a review from keeb January 9, 2025 23:24
Copy link

github-actions bot commented Jan 9, 2025

Dependency Review

✅ No vulnerabilities or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

Copy link
Contributor

@wendybujalski wendybujalski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jobelenus jobelenus added this pull request to the merge queue Jan 9, 2025
Merged via the queue into main with commit df209b3 Jan 9, 2025
9 checks passed
@jobelenus jobelenus deleted the fix/BUG-735-consolidate-logic branch January 9, 2025 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants