Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(web) - minor improvements and fixes to the auth portal token UI #5226

Merged
merged 1 commit into from
Jan 9, 2025
Merged

feat(web) - minor improvements and fixes to the auth portal token UI #5226

merged 1 commit into from
Jan 9, 2025

Conversation

wendybujalski
Copy link
Contributor

🔑

@wendybujalski wendybujalski requested a review from jkeiser January 9, 2025 19:04
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025

Dependency Review

✅ No vulnerabilities or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

vbustamante
vbustamante approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@vbustamante vbustamante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see what this PR is doing and it makes sense, but also it would be cool to have more than "minor improvements and fixes" as the title/a description

e.g. "Make the workspace settings link on the tokens page an IconButton"

@wendybujalski wendybujalski added this pull request to the merge queue Jan 9, 2025
Merged via the queue into main with commit 0395e97 Jan 9, 2025
9 checks passed
@wendybujalski wendybujalski deleted the wendy/token-ui-improvements branch January 9, 2025 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbustamante vbustamante vbustamante approved these changes

@jkeiser jkeiser jkeiser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wendybujalski @jkeiser @vbustamante