Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Fix hash link to #components #5225

Closed
wants to merge 2 commits into from
Closed

[docs] Fix hash link to #components #5225

wants to merge 2 commits into from

Conversation

sandalwing
Copy link
Contributor

I noticed this in the docs wasn't redirecting right. This patch should fix the issue.

@github-actions github-actions bot added community Submitted by a community person A-docs Area: Project documentation A-auth labels Jan 9, 2025
@systeminitbot
Copy link

Hello! Thank your for your pull request. It looks like you are not on the contributors list, or
there is an error with the list. You can check CI logs for more details.

For information on how to add yourself to the contributors list and what it means for you, see the
contributing guide!

@johnrwatson johnrwatson self-requested a review January 9, 2025 18:17
@johnrwatson
Copy link
Contributor

Hey @sandalwing thanks so much for the contribution.

If you could kindly review contributing guide and add yourself to https://github.com/systeminit/si/blob/main/CONTRIBUTORS.md we can work this through 👍

@sandalwing
Copy link
Contributor Author

Sure!

@sandalwing
Copy link
Contributor Author

OK, I added myself to CONTRIBUTORS.

johnrwatson
johnrwatson approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@johnrwatson johnrwatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for taking the time to do that.

@johnrwatson johnrwatson enabled auto-merge January 9, 2025 20:13
@stack72 stack72 disabled auto-merge January 9, 2025 21:44
@stack72 stack72 enabled auto-merge January 9, 2025 21:46
@sandalwing
Copy link
Contributor Author

sandalwing commented Jan 9, 2025 •
edited
Loading

np!

@stack72 stack72 disabled auto-merge January 9, 2025 23:26
@stack72 stack72 closed this Jan 9, 2025
@stack72 stack72 reopened this Jan 9, 2025
@stack72 stack72 mentioned this pull request Jan 9, 2025
Merged
@stack72 stack72 enabled auto-merge January 9, 2025 23:38
@stack72 stack72 closed this Jan 9, 2025
auto-merge was automatically disabled January 9, 2025 23:38

Pull request was closed

@stack72
Copy link
Contributor

stack72 commented Jan 9, 2025

Hey @sandalwing

There's something wrong with this PR - so I opened #5228 and cherry-picked your commits across to keep the lineage so we can merge it

Thanks

Paul

@sandalwing
Copy link
Contributor Author

no prob! thx! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnrwatson johnrwatson johnrwatson approved these changes

Assignees
No one assigned
Labels
A-auth A-docs Area: Project documentation community Submitted by a community person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sandalwing @systeminitbot @johnrwatson @stack72