Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sdf): Ensure we match intrinsics schema variants as well as components #5188

Merged
merged 1 commit into from
Dec 20, 2024
Merged

fix(sdf): Ensure we match intrinsics schema variants as well as components #5188

merged 1 commit into from
Dec 20, 2024

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented Dec 20, 2024

No description provided.

@github-actions github-actions bot added the A-sdf Area: Primary backend API service [Rust] label Dec 20, 2024
@stack72 stack72 requested a review from fnichol December 20, 2024 22:48
fnichol
fnichol approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@fnichol fnichol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We confirmed the corrected behavior locally, and as this code is exercised in a function authoring context (i.e. not modelling) running the scenario 1flow shouldn't call this change

@stack72 stack72 added this pull request to the merge queue Dec 20, 2024
@stack72 stack72 removed this pull request from the merge queue due to a manual request Dec 20, 2024
@fnichol fnichol added this pull request to the merge queue Dec 20, 2024
@fnichol
Copy link
Contributor

fnichol commented Dec 20, 2024

I ran through our "scenario 1" anyway to confirm it behaves as expected

Merged via the queue into main with commit d1dc6cd Dec 20, 2024
8 checks passed
@fnichol fnichol deleted the bind-intrinsics-panel-correctly branch December 20, 2024 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fnichol fnichol fnichol approved these changes

Assignees
No one assigned
Labels
A-sdf Area: Primary backend API service [Rust]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stack72 @fnichol