Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rip: confetti #5163

Merged
merged 1 commit into from
Dec 19, 2024
Merged

rip: confetti #5163

merged 1 commit into from
Dec 19, 2024

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented Dec 18, 2024

it has served us well but it's the time to remove it

@github-actions github-actions bot added the A-web label Dec 18, 2024
nickgerace
nickgerace previously approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@nickgerace nickgerace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://www.youtube.com/watch?v=lpZiPZwwXhM

@stack72
rip: confetti
1575740 
it has served us well but it's the time to remove it
@wendybujalski
Copy link
Contributor

😭

@stack72 stack72 added this pull request to the merge queue Dec 18, 2024
@stack72 stack72 removed this pull request from the merge queue due to a manual request Dec 18, 2024
@wendybujalski wendybujalski self-requested a review December 18, 2024 23:31
wendybujalski
wendybujalski requested changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@wendybujalski wendybujalski left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the unnecessary Teleport on line 20 of App.vue and this will be good to go

app/web/src/App.vue Outdated Show resolved Hide resolved
@stack72
Copy link
Contributor Author

stack72 commented Dec 18, 2024

app/web/src/App.vue

done!!

@wendybujalski wendybujalski self-requested a review December 18, 2024 23:35
wendybujalski
wendybujalski approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@wendybujalski wendybujalski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😭

@stack72 stack72 added this pull request to the merge queue Dec 19, 2024
Merged via the queue into main with commit 8aff0d2 Dec 19, 2024
8 checks passed
@stack72 stack72 deleted the rip-confetti branch December 19, 2024 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wendybujalski wendybujalski wendybujalski approved these changes

@nickgerace nickgerace nickgerace left review comments

@jobelenus jobelenus Awaiting requested review from jobelenus

Assignees
No one assigned
Labels
A-web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stack72 @wendybujalski @nickgerace