chore: disable the foyer disk cache #5154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/try |
|
Okay, starting a try! I'll update this comment once it's running...\n |
fnichol
approved these changes
Dec 18, 2024
|
|
||
| Ok(Self { cache }) | ||
| } | ||
|
|
||
| pub async fn get(&self, key: &str) -> Option<V> { | ||
| match self.cache.obtain(key.into()).await { | ||
| Ok(Some(entry)) => match entry.value() { | ||
| match self.cache.get(key) { |
There was a problem hiding this comment.
If memory serves this doesn't really change the sematics, but rather a change in API because we're dealing with a MemCache rather than a HybridCache?
There was a problem hiding this comment.
Correct, obtain de-dups calls to the disk, so no disk, no obtain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This disables the disk cache portion of Foyer as we investigate issues with memory growing unbounded, leading to OOMs in production environments. Local testing indicates that the disk portion of the cache and the rate at which we flush to it may be causing us to greatly over allocate memory. More investigation needs to happen in this area, so this is mainly to stabilize prod.