toasts and other UI adjustments for template generation #5145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wendybujalski
commented
Dec 17, 2024
wendybujalski
commented
jobelenus
reviewed
Dec 17, 2024
| @@ -129,6 +129,9 @@ const runPrototype = async (viewId: ViewId) => { | |||
| ); | |||
|
|
|||
| if (result.result.success) { | |||
| // TODO(WENDY) - for template functions, select the returned componentIds | |||
| // modelingEventBus.emit("setSelection", componentIds); | |||
There was a problem hiding this comment.
Does this need to be done? Also, I dont think we need the event bus... its just an action in the view store now...
jobelenus
reviewed
Dec 17, 2024
|
|
||
| return new ApiRequest({ |
There was a problem hiding this comment.
I prefer the return style, b/c things start to break if ApiRequest isn't returned.
jobelenus
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.