WIP: split out approvals API #5144
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickgerace
force-pushed
the
nick-jacob-jobelenus/eng-2884
branch
4 times, most recently
from
d2a8c59 to
3c1a267
Compare
nickgerace
changed the title
nickgerace
force-pushed
the
nick-jacob-jobelenus/eng-2884
branch
from
3c1a267 to
145a4d5
Compare
- Add change set approvals table with integration test - Collect approval status for a change set (only current approvals right now and without the validity check) - Add new approval route - Detect added, removed and changed nodes - Collapse the dectector into one module and rename it - Rename new change detection logic to "detect_changes" - Add new unit test for "detect_changes" - Calculate changes hash in an integration test - Move changes hash contents into approval - Generate the checksum upon approval (which may come from the frontend in the future due to potential desync issues, etc.) - Calculate the "is_valid" check for real Co-authored-by: Jacob Helwig <[email protected]> Co-authored-by: John Obelenus <[email protected]> Signed-off-by: Nick Gerace <[email protected]>
nickgerace
force-pushed
the
nick-jacob-jobelenus/eng-2884
branch
from
145a4d5 to
07a1bb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.