Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdf, dal): Adding the ability to set a webhook url for a workspace #5095

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented Dec 10, 2024

We currently only post to that webhook from the change set approval flow but we want to make this more of an opt-in to what you can / can't to

@github-actions github-actions bot added A-sdf Area: Primary backend API service [Rust] A-dal A-web labels Dec 10, 2024
@nickgerace nickgerace self-requested a review December 10, 2024 18:25
lib/sdf-server/src/service/v2/change_set.rs Outdated Show resolved Hide resolved
lib/si-id/src/lib.rs Outdated Show resolved Hide resolved
We currently only post to that webhook from the change set approval flow but we want to make this more of an opt-in to what you can / can't to
@stack72 stack72 force-pushed the slack-webhook-for-changeset-events branch from f6dec5d to a7c70c3 Compare December 10, 2024 22:47
@stack72 stack72 added this pull request to the merge queue Dec 10, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 10, 2024
@nickgerace nickgerace added this pull request to the merge queue Dec 10, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 10, 2024
@stack72 stack72 added this pull request to the merge queue Dec 10, 2024
Merged via the queue into main with commit 794d87e Dec 10, 2024
9 checks passed
@stack72 stack72 deleted the slack-webhook-for-changeset-events branch December 10, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dal A-sdf Area: Primary backend API service [Rust] A-web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants