feat: support multiple jwt public keys #5090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-si-settings
zacharyhamm
force-pushed
the
zack/support-multiple-signing-keys
branch
2 times, most recently
from
69bdb8d to
da87f8f
Compare
zacharyhamm
force-pushed
the
zack/support-multiple-signing-keys
branch
4 times, most recently
from
4f768d6 to
c57385f
Compare
sprutton1
previously approved these changes
Dec 9, 2024
zacharyhamm
force-pushed
the
zack/support-multiple-signing-keys
branch
from
c57385f to
27d25c3
Compare
stack72
previously approved these changes
Dec 10, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Support two JWT keys. One used for signing (the primary private key), and an extra one for verification, so that we can rotate keys without downtime, and then remove the "secondary" if desired. It also now possible to specify the key algorithm. ES256 and RS256 are supported but RS256 will be removed. Adds a new crate, `si-jwt-public-key` (since this logic needs to be shared between sdf and the module-index).
zacharyhamm
force-pushed
the
zack/support-multiple-signing-keys
branch
from
27d25c3 to
050eb5c
Compare
stack72
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support two JWT keys. One used for signing (the primary private key), and an extra one for verification, so that we can rotate keys without downtime, and then remove the "secondary" if desired. It also now possible to specify the key algorithm. ES256 and RS256 are supported but RS256 will be removed.
Adds a new crate,
si-jwt-public-key(since this logic needs to be shared between sdf and the module-index).