feat: add workspace separation between API tests #4753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnrwatson
force-pushed
the
feat/stop-paging-brit
branch
from
126c291 to
577bf20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds workspace separation to API tests to prevent clashes / pining us at random intervals.
Also means we can investigate failures on an individual test basis by looking at the correct workspace, which might be nice.
There could be a turn here to add a default workspace for any
newtests, so that community members can contribute a test and have it pass without us having to add a new workspace for it, but that can be a future turn if we even decide to continue down this route for good.Pass against Prod: https://github.com/systeminit/si/actions/runs/11255323803
Pass against Tools: https://github.com/systeminit/si/actions/runs/11255056948