Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, if you update a secret in-place and then quickly click on a component that uses it (after rebase but before DVU), an error toast pops up saying it couldn't find the secret.
This is because when we get the property values for a component for editing, we try to look up the secret by matching the key stored in the dependent value (cached in the node) against the keys in all Secret node. Since the secret key has since been updated, the secret can't be found. It eventually gets better, but it happens enough to drive John Watson crazy.
This change gets us past the error by sending back null (telling the frontend it's not set). Going forward, we'll talk through how to handle situations where dependent values aren't up to date with @wendybujalski and @jobelenus -- there is a general problem to solve there, as @jhelwig points out. And we should consider whether we should include more information (such as the secret id) in the JSON value for secrets, to reduce how often this will affect people. (Even if we did that, the problem would persist when the secret is deleted.)
This only affects the property editor value calculation.
Fixes BUG-481.