feat: add maintenance timeout to toast as 60s #4382
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnrwatson
force-pushed
the
feat/add-timeout-to-maintenance-toast
branch
2 times, most recently
from
fc6689b to
278de2c
Compare
This commit removes an unused oneshot channel from the recent USR2 signal handling work in sdf (#4368). Additional changes: - Move the maintenance mode message into a constant in order to make the code more readable - Rename "Result" to "ServerResult" for clarity in "server/server.rs" - Re-order imports to match style Signed-off-by: Nick Gerace <[email protected]>
johnrwatson
force-pushed
the
feat/add-timeout-to-maintenance-toast
branch
from
278de2c to
17e8007
Compare
github-actions
bot
added
A-sdf
|
Accidentally rebased in Nick's commits, will re-do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a basic timeout to the maintenance toast so it doesn't need to be dismissed by the user. We don't need a reload here either as the service should just kick back in and resolve the session again on the next API call.
NB: Also fixed a minor typo in
sed s/maintanance/maintenance/gfile naming