fix(dal): speed up get diagram #4380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid expensive recomputation of various values in get_diagram. Provides about a 50% speedup locally. Also removes some telemetry on workspace snapshot that would be mostly noise, and would overwhelm the collector in debug mode.
zacharyhamm
force-pushed
the
zack/improve-get-diagram-perf
branch
from
f2ca49d to
4878e93
Compare
nickgerace
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid expensive recomputation of various values in get_diagram. Provides about a 50% speedup locally. Also removes some noisy telemetry