Remove unused oneshot channel from USR2 sdf work #4376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickgerace
commented
Aug 20, 2024
| let (graceful_shutdown_tx, graceful_shutdown_rx) = oneshot::channel::<()>(); | ||
| let (_application_mode_tx, application_mode_rx) = oneshot::channel::<()>(); |
This commit removes an unused oneshot channel from the recent USR2 signal handling work in sdf (#4368). Additional changes: - Move the maintenance mode message into a constant in order to make the code more readable - Rename "Result" to "ServerResult" for clarity in "server/server.rs" - Re-order imports to match style Signed-off-by: Nick Gerace <[email protected]>
nickgerace
force-pushed
the
nick/eng-2640
branch
from
f4b7278 to
28f1d53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes an unused oneshot channel from the recent USR2 signal handling work in sdf (#4368).
Additional changes
ResulttoServerResultfor clarity inserver/server.rs