Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: web otel traces should not include the port by default #4366

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Conversation

sprutton1
Copy link
Contributor

window.location.host includes the port, so we don't need to specify it here. It will be set by env vars at build time otherwise

@github-actions github-actions bot added the A-web label Aug 19, 2024
@sprutton1 sprutton1 enabled auto-merge August 19, 2024 21:23
@sprutton1 sprutton1 added this pull request to the merge queue Aug 19, 2024
Merged via the queue into main with commit 995d13f Aug 19, 2024
8 checks passed
@sprutton1 sprutton1 deleted the otel_fix branch August 19, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant