Retain validations from asset func on regeneration #4042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickgerace
commented
Jun 25, 2024
Comment on lines
+308
to
+310
| if let Some(validation_format) = &self.validation_format { | ||
| builder.validation_format(validation_format); | ||
| } |
There was a problem hiding this comment.
This was the bug.
Comment on lines
+232
to
+233
| /// Extracts the value and validation from a raw property edtior value. | ||
| pub fn extract_value_and_validation( |
There was a problem hiding this comment.
Moved while authoring a test that I used to find the bug. The test was discarded, but this should be useful for bubbling up errors.
| @@ -474,7 +474,7 @@ | |||
| <div | |||
| v-if="showValidationDetails && validation" | |||
| :style="{ marginLeft: indentPx }" | |||
| class="text-red-400 flex flex-col bg-black pl-3 border-y border-red-400 pb-1 my-1" | |||
| class="flex flex-col pl-3 border pb-1 m-2 text-destructive-500 border-destructive-500 bg-destructive-100 dark:text-destructive-900 dark:border-destructive-900 dark:bg-destructive-500" | |||
There was a problem hiding this comment.
This is likely not the final turn here, but what was there was definitely incorrect.
This commit retains validations from asset funcs upon regeneration. Currently, we successfully execute the asset func when regenerating an asset. We see the validations in the resulting definition. However, when exporting using the definition and converting it into a spec, the validations are dropped. This commit ensures that are no longer dropped. This commit also contains minor changes to how validations appear in the attribute panel. The existing classes relied on colors outside of our asset panel and neither matcher our light nor our dark theme. While the current colors are not likely the final ones, they are closer to our design language (even if only a little). Disclaimer: this will require all affected assets to be regenerated and re-exported, as applicable. Signed-off-by: Nick Gerace <[email protected]>
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR retains validations from asset funcs upon regeneration. Currently, we successfully execute the asset func when regenerating an asset. We see the validations in the resulting definition. However, when exporting using the definition and converting it into a spec, the validations are dropped. This PR ensures that are no longer dropped.
This PR also contains minor changes to how validations appear in the attribute panel. The existing classes relied on colors outside of our asset panel and neither matcher our light nor our dark theme. While the current colors are not likely the final ones, they are closer to our design language (even if only a little).
Disclaimer
This will require all affected assets to be regenerated and re-exported, as applicable.