Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cypress on cron, cancel on deploy #4037

Merged
merged 1 commit into from
Jun 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions .github/workflows/crons.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
on:
schedule:
- cron: '*/15 * * * *' # Runs every 15 minutes

# We want to ensure that in-progress cron runs are canceled
# when do a deploy so they don't fail erroneously, but these
# cannot cancel deploys
concurrency:
group: e2e
cancel-in-progress: false

jobs:
e2e-validation:
uses: ./.github/workflows/e2e-validation.yml
with:
environment: tools
secrets: inherit
7 changes: 7 additions & 0 deletions .github/workflows/deploy-on-main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,13 @@ on:
push:
branches:
- main

# We want to ensure that in-progress cron runs are canceled
# when do a deploy so they don't fail erroneously
concurrency:
group: e2e
cancel-in-progress: true

jobs:
deploy-tools-prod:
uses: ./.github/workflows/deploy-stack.yml
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/e2e-validation.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
name: Cypress E2E Tests

on:
# schedule:
# - cron: '*/5 * * * *' # Runs every 5 minutes
workflow_call:
inputs:
environment:
Expand Down Expand Up @@ -30,7 +28,9 @@ jobs:
fail-fast: false
matrix:
# run copies of the current job in parallel
containers: [1] # , 2, 3, 4, 5, 6, 7, 8, 9, 10] - temp disabled mass
# TODO: we really should build once and set it as an
# artifact so we aren't rebuilding for each of these
containers: [1, 2, 3] #, 4, 5, 6, 7, 8, 9, 10] - temp disabled mass
steps:
- name: Checkout code
uses: actions/checkout@v3
Expand Down
Loading