Merge pull request #5120 from systeminit/fix(web)-Change-the-number-o…

…f-changesets-and-workspaces-before-search-hits fix(web): Change the number of changesets and workspaces before search hits
systeminit · Dec 12, 2024 · ae2025d · ae2025d
2 parents 3897160 + 6ca36a5
commit ae2025d
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/app/web/src/components/layout/navbar/ChangeSetPanel.vue b/app/web/src/components/layout/navbar/ChangeSetPanel.vue
@@ -10,7 +10,9 @@
         ref="dropdownMenuRef"
         v-model="selectedChangeSetId"
         :options="changeSetSearchFilteredOptions"
-        :search="changeSetDropdownOptions.length > 20"
+        :search="
+          changeSetDropdownOptions.length > DEFAULT_DROPDOWN_SEARCH_THRESHOLD
+        "
         placeholder="-- select a change set --"
         checkable
         variant="navbar"
@@ -126,6 +128,7 @@ import {
   useValidatedInputGroup,
   DropdownMenuButton,
   DropdownMenuItem,
+  DEFAULT_DROPDOWN_SEARCH_THRESHOLD,
 } from "@si/vue-lib/design-system";
 import { useChangeSetsStore } from "@/store/change_sets.store";
 import { ChangeSetStatus } from "@/api/sdf/dal/change_set";

diff --git a/app/web/src/components/layout/navbar/NavbarPanelLeft.vue b/app/web/src/components/layout/navbar/NavbarPanelLeft.vue
@@ -14,7 +14,9 @@
         ref="dropdownMenuRef"
         v-model="selectedWorkspacePk"
         :options="searchFilteredWorkspaceDropdownOptions"
-        :search="workspaceDropdownOptions.length > 20"
+        :search="
+          workspaceDropdownOptions.length > DEFAULT_DROPDOWN_SEARCH_THRESHOLD
+        "
         placeholder="-- select a workspace --"
         checkable
         variant="navbar"
@@ -43,6 +45,7 @@
 import * as _ from "lodash-es";
 import SiLogo from "@si/vue-lib/brand-assets/si-logo-symbol.svg?component";
 import {
+  DEFAULT_DROPDOWN_SEARCH_THRESHOLD,
   DropdownMenuButton,
   DropdownMenuItem,
   Icon,

diff --git a/lib/vue-lib/src/design-system/index.ts b/lib/vue-lib/src/design-system/index.ts
@@ -38,6 +38,7 @@ export { default as DropdownMenu } from "./menus/DropdownMenu.vue";
 export type { DropdownMenuItemObjectDef } from "./menus/DropdownMenu.vue";
 export { default as DropdownMenuItem } from "./menus/DropdownMenuItem.vue";
 export { default as DropdownMenuButton } from "./menus/DropdownMenuButton.vue";
+export const DEFAULT_DROPDOWN_SEARCH_THRESHOLD = 10;
 
 // ./modals
 export { default as Modal } from "./modals/Modal.vue";