Merge pull request #4196 from systeminit/fix/dont-show-edges-if-socke…

…t-is-gone Fix: dont show edge if socket is gone
systeminit · Jul 23, 2024 · a2e3741 · a2e3741
2 parents a9f4e31 + 54ebdc8
commit a2e3741
Showing 1 changed file with 11 additions and 5 deletions.
diff --git a/app/web/src/store/components.store.ts b/app/web/src/store/components.store.ts
@@ -522,11 +522,17 @@ export const useComponentsStore = (forceChangeSetId?: ChangeSetId) => {
           },
 
           diagramEdges(): DiagramEdgeDef[] {
-            return _.filter(this.allEdges, (edge) => {
-              return (
-                !!this.componentsById[edge.toComponentId] &&
-                !!this.componentsById[edge.fromComponentId]
-              );
+            // filter out edge data if neither component exists
+            // or the toComponent Socket doesn't exist
+            return this.allEdges.filter((edge) => {
+              const toComponent = this.componentsById[edge.toComponentId];
+              if (!this.componentsById[edge.fromComponentId]) return false;
+              if (!toComponent) return false;
+              else if (
+                !toComponent.sockets.find((s) => s.id === edge.toSocketId)
+              )
+                return false;
+              return true;
             });
           },