Skip to content

Commit

Permalink
merge: #4014
Browse files Browse the repository at this point in the history
4014: fix(si-generator): Ensure we treat missingResources as optional r=stack72 a=stack72



Co-authored-by: stack72 <[email protected]>
  • Loading branch information
si-bors-ng[bot] and stack72 authored Jun 21, 2024
2 parents 2c76214 + b4775bc commit 8e6bb4a
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions bin/si-generator/src/resource_generator.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ export function parseOutputOption(output: string): ArgOutput {

export function makeRefreshOptions(options: {
input: Array<string>;
missingResource: Array<string>;
missingResource?: Array<string>;
output: Array<string>;
}): RefreshOptions {
const refreshOptions: RefreshOptions = {
Expand All @@ -52,8 +52,10 @@ export function makeRefreshOptions(options: {
const argInput = parseInputOption(input);
refreshOptions.inputs.push(argInput);
}
for (const missing of options.missingResource) {
refreshOptions.missingResources.push(missing);
if (options.missingResource) {
for (const missing of options.missingResource) {
refreshOptions.missingResources.push(missing);
}
}
for (const output of options.output) {
const argOutput = parseOutputOption(output);
Expand Down

0 comments on commit 8e6bb4a

Please sign in to comment.