Merge pull request #5266 from systeminit/wendy/bug-729-multiple-click…

…s-required-to-be-able-to-bind-an-output-socket fix(web) - BUG-729, multiple clicks, recomputing unmounting
systeminit · Jan 15, 2025 · 1c713bf · 1c713bf
2 parents bebdfe9 + c9dfe1a
commit 1c713bf
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 5 deletions.
diff --git a/app/web/src/components/AssetDetailIntrinsicInput.vue b/app/web/src/components/AssetDetailIntrinsicInput.vue
@@ -102,7 +102,11 @@ const label = computed<string>(() => {
 watch(
   () => props.data,
   () => {
-    display.value = toRaw(props.data);
+    // we need to make a shallow copy of props.data
+    // in order to prevent the parent AssetDetailsPanel from
+    // recomputing outputSocketIntrinsics which causes this component
+    // to be unmounted/mounted which resets the selectedFilter :(
+    display.value = { ...toRaw(props.data) };
   },
   { immediate: true },
 );
@@ -150,10 +154,12 @@ const selectFilter = (item: DropdownFilter) => {
 
   selectedFilter.value = item;
 
+  const c = { ...display.value };
+
   if (item === "unset") {
-    emit("changeToUnset", display.value);
+    emit("changeToUnset", c);
   } else {
-    emit("changeToIdentity", display.value, null);
+    emit("changeToIdentity", c, null);
   }
 };
 

diff --git a/app/web/src/components/AssetDetailsPanel.vue b/app/web/src/components/AssetDetailsPanel.vue
@@ -541,7 +541,6 @@ const updateOutputSocketIntrinsics = async (data: IntrinsicDisplay) => {
 
 const changeToUnset = (config: PropDisplay | IntrinsicDisplay | undefined) => {
   if (!config) return;
-
   config.attributePrototypeId = undefined;
   config.funcId = unsetFuncId.value;
   config.value = undefined;
@@ -565,7 +564,9 @@ const changeToIdentity = (
   // dont fire a save if there isnt a value
   if ("backendKind" in config) {
     config.backendKind = FuncBackendKind.Identity;
-    if (config.value) updateOutputSocketIntrinsics(config);
+    if (config.value) {
+      updateOutputSocketIntrinsics(config);
+    }
   } else if (config.value) {
     updatePropIntrinsics(config);
   }