Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/751 Add optional BUILD_DEBUG Docker build argument #753

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

oobayly
Copy link
Contributor

@oobayly oobayly commented Sep 9, 2024

See #751

Makes it easier to enable debugging for the docker image. Passing an optional BUILD_DEBUG argument with a non-empty value:

  • Runs cmake with the -DCMAKE_BUILD_TYPE=Debug flag
  • Doesn't strip the executables after they're build
  • Installs gdb

docker build --build-arg BUILD_DEBUG=1 --tag tilemaker/debug .

@oobayly oobayly changed the title Feature/751 Add optional BUILD_DEBUG build argument Feature/751 Add optional BUILD_DEBUG Docker build argument Sep 9, 2024
@systemed systemed merged commit 94c0040 into systemed:master Oct 18, 2024
7 checks passed
@systemed
Copy link
Owner

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants