Introduce Valgrind to the CI pipeline

[henrybear327]

The static analyzer alone can't catch all the runtime issues. In this commit, the dynamic analysis tool Valgrind is added to the CI pipeline.

ENABLE_SDL is set to 0, in order to reduce noise caused by the external
libraries.

Reference:

• https://valgrind.org/docs/manual/quick-start.html
• https://linux.die.net/man/1/gcc

[henrybear327]

To merge this pull request, all the memory-related leaks need to be addressed first.

Currently, based on my initial testing, when disabling SDL and JIT, no memory leaks are found. When enabling JIT, there will be plenty of leaks.

[jserv]

Memory leaks of JIT compiler reported by Valgrind:

• definitely lost: 144 bytes in 4 blocks
• indirectly lost: 132 bytes in 9 blocks
• still reachable: 64 bytes in 3 blocks

[jserv]

Benchmarks

Benchmark suite	Current: 53dabb2	Previous: b80dcb4	Ratio
Dhrystone	3.44 Average DMIPS over 10 runs	12.37 Average DMIPS over 10 runs	3.60
Coremark	0.003 Average iterations/sec over 10 runs	0.005 Average iterations/sec over 10 runs	1.67

This comment was automatically generated by workflow using github-action-benchmark.

[henrybear327]

Memory leaks of JIT compiler reported by Valgrind:

• definitely lost: 144 bytes in 4 blocks
• indirectly lost: 132 bytes in 9 blocks
• still reachable: 64 bytes in 3 blocks

The initial investigation is that the memory leak is detected only when JIT is enabled.

Currently, there are 2 identified leaks so far

• ir->fuse: it allocates memory outside the memory pool. When JIT is enabled, the clean-up logic is missing.
• releasing allocated memory after the memory arena expansion

[jserv]

The initial investigation is that the memory leak is detected only when JIT is enabled.
Currently, there are 2 identified leaks so far

• ir->fuse: it allocates memory outside the memory pool. When JIT is enabled, the clean-up logic is missing.
• releasing allocated memory after the memory arena expansion

@qwe661234, can you comment this?

[henrybear327]

The initial investigation is that the memory leak is detected only when JIT is enabled.
Currently, there are 2 identified leaks so far

• ir->fuse: it allocates memory outside the memory pool. When JIT is enabled, the clean-up logic is missing.
• releasing allocated memory after the memory arena expansion

@qwe661234, can you comment this?

Reference:

rv32emu/src/riscv.c

Line 61 in ef151e2

free(ir->fuse);

[qwe661234]

The initial investigation is that the memory leak is detected only when JIT is enabled.
Currently, there are 2 identified leaks so far

• ir->fuse: it allocates memory outside the memory pool. When JIT is enabled, the clean-up logic is missing.
• releasing allocated memory after the memory arena expansion

@qwe661234, can you comment this?

Reference:

rv32emu/src/riscv.c

Line 61 in ef151e2

free(ir->fuse);

This function is only using in non-JIT mode, the basic block information is stored in block cache in JIT mode. Therefore, I need to add a free for ir->fuse when clear block cache.

[jserv]

Rebase the latest master branch.

[jserv]

The build system is being reworked (#473), and I am about to close this pull request. Let's introduce Valgrind to CI pipeline later.