Consolidate logging with a unified interface #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jouae
reviewed
Sep 13, 2024
There was a problem hiding this comment.
"FIXME: Both twin_private.h and log.h are private header files."
What issue is this statement trying to fix?
There was a problem hiding this comment.
"FIXME: Both twin_private.h and log.h are private header files." What issue is this statement trying to fix?
See #9
Currently, various messages are displayed while the window system is running, but their format and usage are inconsistent. Additionally, depending on the scenario, it may be useful to adjust the color scheme or disable logging output altogether. The rxi/log.c [1] offers a robust solution for these needs, and it would be beneficial to integrate it into the core implementation of the window system to standardize logging and enhance flexibility. - log_trace - log_debug - log_info - log_warn - log_error - log_fatal [1] https://github.com/rxi/log.c Close #47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, various messages are displayed while the window system is running, but their format and usage are inconsistent. Additionally, depending on the scenario, it may be useful to adjust the color scheme or disable logging output altogether.
The rxi/log.c offers a robust solution for these needs, and it would be beneficial to integrate it into the core implementation of the window system to standardize logging and enhance flexibility.
log_tracelog_debuglog_infolog_warnlog_errorlog_fatalClose #47