Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move private header file to src #11

Closed
wants to merge 2 commits into from

Conversation

Damien-Chen
Copy link
Contributor

Move "twin_private.h" to src folder, and make a new "util.h" header file that include necessary header file for the expansion of future use.

Copy link
Contributor

@jserv jserv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The header twin_private.h is used internally, and don't create any header referring to it. See #9

@Damien-Chen
Copy link
Contributor Author

Damien-Chen commented Jul 18, 2024

Based on my understanding, so we can directory include twin_private.h in source code, but indirectory include is no need right ? (based on my change, I create util.h include twin_private.h)

@jserv
Copy link
Contributor

jserv commented Jul 18, 2024

Based on my understanding, so we can directory include twin_private.h in source code, but indirectory include is no need right ?

The include directory should contain twin.h as the public header and nothing more, meaning that the current twin_private.h is a hack to allow the building of some applications invoking the internal functions. You can proceed with issue #9 to contribute to this project.

@jserv
Copy link
Contributor

jserv commented Jul 18, 2024

Close to concentrate on #9

@jserv jserv closed this Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants