Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port pdf_watermark field on IPublication #184

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Conversation

reinhardt
Copy link
Contributor

@reinhardt reinhardt requested a review from thet July 8, 2024 07:45
Copy link
Member

@thet thet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the code where this field is used is already in place (in src/recensio/plone/browser/pdfgen.py, right?)
LGTM.

@reinhardt
Copy link
Contributor Author

Yes, and the old values are migrated, only changing them is currently not possible.

@reinhardt reinhardt merged commit 26de0d1 into main Jul 8, 2024
3 checks passed
@reinhardt reinhardt deleted the scrum-2385-pdf-watermark branch July 8, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants