fix(shield): add default host shield tolerations and affinity #1968
+176
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlbertoBarba
requested changes
Oct 8, 2024
| {{- with $affinity -}} | ||
| {{- . | toYaml -}} | ||
| {{- end -}} | ||
| {{- else -}} | ||
| nodeAffinity: |
There was a problem hiding this comment.
Why don't we set this as default in the values for host.affinity?
| @@ -206,7 +206,23 @@ host: | |||
| # The node selector for the host shield | |||
| node_selector: {} | |||
| # The tolerations for the host shield | |||
| tolerations: [] | |||
| tolerations: | |||
There was a problem hiding this comment.
Suggested change
| tolerations: | |
| tolerations: # +doc-gen:break |
And re-run make docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The Shield chart was not defining a default set of node affinity and toleration settings which resulted in the Host Shield not being installed on expected nodes.
Checklist
feat(agent,node-analyzer,sysdig-deploy):)