Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rfq-relayer): regenerate with updated fastbridgev2 and zap terminology [SLT-442] #3393

Closed
wants to merge 102 commits into from

Cleanup: remove logs

b3faf2b
Select commit
Loading
Failed to load commit list.
Closed

feat(rfq-relayer): regenerate with updated fastbridgev2 and zap terminology [SLT-442] #3393

Cleanup: remove logs
b3faf2b
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / Slither completed Nov 14, 2024 in 6s

1 configuration not found

Warning: Code scanning may not have found all the alerts introduced by this pull request, because 1 configuration present on refs/heads/master was not found:

Actions workflow (solidity.yml)

  • ❓  .github/workflows/solidity.yml:slither/package:contracts-core

New alerts in code changed by this pull request

Security Alerts:

  • 3 low

Other Alerts:

  • 3 warnings

See annotations below for details.

View all branch alerts.

Annotations

Check notice on line 134 in packages/contracts-rfq/contracts/FastBridgeV2.sol

See this annotation in the file changed.

Code scanning / Slither

Block timestamp Low

FastBridgeV2.refund(bytes) uses timestamp for comparisons
Dangerous comparisons:
- block.timestamp <= deadline

Check notice on line 364 in packages/contracts-rfq/contracts/FastBridgeV2.sol

See this annotation in the file changed.

Code scanning / Slither

Block timestamp Low

FastBridgeV2.claim(bytes,address) uses timestamp for comparisons
Dangerous comparisons:
- _timeSince(proofBlockTimestamp) <= DISPUTE_PERIOD

Check notice on line 481 in packages/contracts-rfq/contracts/FastBridgeV2.sol

See this annotation in the file changed.

Check warning on line 2 in packages/contracts-rfq/contracts/interfaces/IAdmin.sol

See this annotation in the file changed.

Code scanning / Slither

Incorrect versions of Solidity Warning

Version constraint ^0.8.4 contains known severe issues (https://solidity.readthedocs.io/en/latest/bugs.html)
- FullInlinerNonExpressionSplitArgumentEvaluationOrder
- MissingSideEffectsOnSelectorAccess
- AbiReencodingHeadOverflowWithStaticArrayCleanup
- DirtyBytesArrayToStorage
- DataLocationChangeInInternalOverride
- NestedCalldataArrayAbiReencodingSizeValidation
- SignedImmutables.
It is used by:
- ^0.8.4
- ^0.8.4
- ^0.8.4
- ^0.8.4
- ^0.8.4

Check warning on line 2 in packages/contracts-rfq/contracts/interfaces/IAdmin.sol

See this annotation in the file changed.

Code scanning / Slither

Incorrect versions of Solidity Warning

Version constraint ^0.8.4 contains known severe issues (https://solidity.readthedocs.io/en/latest/bugs.html)
- FullInlinerNonExpressionSplitArgumentEvaluationOrder
- MissingSideEffectsOnSelectorAccess
- AbiReencodingHeadOverflowWithStaticArrayCleanup
- DirtyBytesArrayToStorage
- DataLocationChangeInInternalOverride
- NestedCalldataArrayAbiReencodingSizeValidation
- SignedImmutables.
It is used by:
- ^0.8.4
- ^0.8.4
- ^0.8.4
- ^0.8.4
- ^0.8.4
- ^0.8.4
- ^0.8.4
- ^0.8.4
- ^0.8.4
- ^0.8.4
- ^0.8.4
- ^0.8.4
- ^0.8.4
- ^0.8.4
- ^0.8.4

Check warning on line 232 in packages/contracts-rfq/contracts/libs/BridgeTransactionV2.sol

See this annotation in the file changed.

Code scanning / Slither

Assembly usage Warning

BridgeTransactionV2Lib.zapNative(bytes) uses assembly
- INLINE ASM