Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency @openzeppelin/contracts to v5.1.0 #3337

Closed

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 27, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@openzeppelin/contracts (source) 5.0.1 -> 5.1.0 age adoption passing confidence

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.


Release Notes

OpenZeppelin/openzeppelin-contracts (@​openzeppelin/contracts)

v5.1.0

Compare Source

Breaking changes
  • ERC1967Utils: Removed duplicate declaration of the Upgraded, AdminChanged and BeaconUpgraded events. These events are still available through the IERC1967 interface located under the contracts/interfaces/ directory. Minimum pragma version is now 0.8.21.
  • Governor, GovernorCountingSimple: The _countVote virtual function now returns an uint256 with the total votes casted. This change allows for more flexibility for partial and fractional voting. Upgrading users may get a compilation error that can be fixed by adding a return statement to the _countVote function.
Custom error changes

This version comes with changes to the custom error identifiers. Contracts previously depending on the following errors should be replaced accordingly:

  • Replace Address.FailedInnerCall with Errors.FailedCall
  • Replace Address.AddressInsufficientBalance with Errors.InsufficientBalance
  • Replace Clones.Create2InsufficientBalance with Errors.InsufficientBalance
  • Replace Clones.ERC1167FailedCreateClone with Errors.FailedDeployment
  • Replace Clones.Create2FailedDeployment with Errors.FailedDeployment
  • SafeERC20: Replace Address.AddressEmptyCode with SafeERC20FailedOperation if there is no code at the token's address.
  • SafeERC20: Replace generic Error(string) with SafeERC20FailedOperation if the returned data can't be decoded as bool.
  • SafeERC20: Replace generic SafeERC20FailedOperation with the revert message from the contract call if it fails.
Changes by category
General
  • AccessManager, VestingWallet, TimelockController and ERC2771Forwarder: Added a public initializer function in their corresponding upgradeable variants. (#​5008)
Access
  • AccessControlEnumerable: Add a getRoleMembers method to return all accounts that have role. (#​4546)
  • AccessManager: Allow the onlyAuthorized modifier to restrict functions added to the manager. (#​5014)
Finance
  • VestingWalletCliff: Add an extension of the VestingWallet contract with an added cliff. (#​4870)
Governance
  • GovernorCountingFractional: Add a governor counting module that allows distributing voting power amongst 3 options (For, Against, Abstain). (#​5045)
  • Votes: Set _moveDelegateVotes visibility to internal instead of private. (#​5007)
Proxy
  • Clones: Add version of clone and cloneDeterministic that support sending value at creation. (#​4936)
  • TransparentUpgradeableProxy: Make internal _proxyAdmin() getter have view visibility. (#​4688)
  • ProxyAdmin: Fixed documentation for UPGRADE_INTERFACE_VERSION getter. (#​5031)
Tokens
  • ERC1363: Add implementation of the token payable standard allowing execution of contract code after transfers and approvals. (#​4631)
  • ERC20TemporaryApproval: Add an ERC-20 extension that implements temporary approval using transient storage, based on ERC7674 (draft). (#​5071)
  • SafeERC20: Add "relaxed" function for interacting with ERC-1363 functions in a way that is compatible with EOAs. (#​4631)
  • SafeERC20: Document risks of safeIncreaseAllowance and safeDecreaseAllowance when associated with ERC-7674. (#​5262)
  • ERC721Utils and ERC1155Utils: Add reusable libraries with functions to perform acceptance checks on IERC721Receiver and IERC1155Receiver implementers. (#​4845)
  • ERC1363Utils: Add helper similar to the existing ERC721Utils and ERC1155Utils. (#​5133)
Utils
  • Arrays: add a sort functions for address[], bytes32[] and uint256[] memory arrays. (#​4846)
  • Arrays: add new functions lowerBound, upperBound, lowerBoundMemory and upperBoundMemory for lookups in sorted arrays with potential duplicates. (#​4842)
  • Arrays: deprecate findUpperBound in favor of the new lowerBound. (#​4842)
  • Base64: Add encodeURL following section 5 of RFC4648 for URL encoding (#​4822)
  • Comparator: A library of comparator functions, useful for customizing the behavior of the Heap structure. (#​5084)
  • Create2: Bubbles up returndata from a deployed contract that reverted during construction. (#​5052)
  • Create2, Clones: Mask computeAddress and cloneDeterministic outputs to produce a clean value for an address type (i.e. only use 20 bytes) (#​4941)
  • Errors: New library of common custom errors. (#​4936)
  • Hashes: A library with commonly used hash functions. (#​3617)
  • Packing: Added a new utility for packing, extracting and replacing bytesXX values. (#​4992)
  • Panic: Add a library for reverting with panic codes. (#​3298)
  • ReentrancyGuardTransient: Added a variant of ReentrancyGuard that uses transient storage. (#​4988)
  • Strings: Added a utility function for converting an address to checksummed string. (#​5067)
  • SlotDerivation: Add a library of methods for derivating common storage slots. (#​4975)
  • TransientSlot: Add primitives for operating on the transient storage space using a typed-slot representation. (#​4980)
Cryptography
  • SignatureChecker: refactor isValidSignatureNow to avoid validating ECDSA signatures if there is code deployed at the signer's address. (#​4951)
  • MerkleProof: Add variations of verify, processProof, multiProofVerify and processMultiProof (and equivalent calldata version) with support for custom hashing functions. (#​4887)
  • P256: Library for verification and public key recovery of P256 (aka secp256r1) signatures. (#​4881)
  • RSA: Library to verify signatures according to RFC 8017 Signature Verification Operation (#​4952)
Math
  • Math: add an invMod function to get the modular multiplicative inverse of a number in Z/nZ. (#​4839)
  • Math: Add modExp function that exposes the EIP-198 precompile. Includes uint256 and bytes memory versions. (#​3298)
  • Math: Custom errors replaced with native panic codes. (#​3298)
  • Math, SignedMath: Add a branchless ternary function that computescond ? a : b in constant gas cost. (#​4976)
  • SafeCast: Add toUint(bool) for operating on bool values as uint256. (#​4878)
Structures
  • CircularBuffer: Add a data structure that stores the last N values pushed to it. (#​4913)
  • DoubleEndedQueue: Custom errors replaced with native panic codes. (#​4872)
  • EnumerableMap: add UintToBytes32Map, AddressToAddressMap, AddressToBytes32Map and Bytes32ToAddressMap. (#​4843)
  • Heap: A data structure that implements a heap-based priority queue. (#​5084)
  • MerkleTree: A data structure that allows inserting elements into a merkle tree and updating its root hash. (#​3617)

v5.0.2

Compare Source

  • Base64: Fix issue where dirty memory located just after the input buffer is affecting the result. (#​4926)

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

| datasource | package                 | from  | to    |
| ---------- | ----------------------- | ----- | ----- |
| npm        | @openzeppelin/contracts | 5.0.1 | 5.1.0 |


Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Copy link

cloudflare-workers-and-pages bot commented Oct 27, 2024

Deploying sanguine-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: b2af9f2
Status:🚫  Build failed.

View logs

Copy link
Contributor

coderabbitai bot commented Oct 27, 2024

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Oct 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.27923%. Comparing base (42c0079) to head (b2af9f2).
Report is 1 commits behind head on master.

Additional details and impacted files
@@                 Coverage Diff                 @@
##              master       #3337         +/-   ##
===================================================
+ Coverage   33.25951%   34.27923%   +1.01971%     
===================================================
  Files            543         523         -20     
  Lines          34769       33478       -1291     
  Branches          82          82                 
===================================================
- Hits           11564       11476         -88     
+ Misses         22182       20982       -1200     
+ Partials        1023        1020          -3     
Flag Coverage Δ
packages 90.44834% <ø> (ø)
promexporter ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot deleted the renovate/contracts-rfq-openzeppelin-contracts-5.x branch October 28, 2024 08:10
Copy link
Contributor Author

renovate bot commented Oct 28, 2024

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update (5.1.0). You will get a PR once a newer version is released. To ignore this dependency forever, add it to the ignoreDeps array of your Renovate config.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants