-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(synapse-interface): Linea USDT #2995
Conversation
WalkthroughThe recent updates enhance the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- packages/synapse-interface/constants/tokens/bridgeable.ts (2 hunks)
Additional comments not posted (2)
packages/synapse-interface/constants/tokens/bridgeable.ts (2)
472-472
: Verify the LINEA chain address for USDT.Ensure that the address
0xA219439258ca9da29E9Cc4cE5596924745e12B93
is the correct USDT token address on the LINEA chain.
486-486
: Verify the decimal value for LINEA chain USDT.Ensure that the decimal value
6
is correct for the USDT token on the LINEA chain.Verification successful
Decimal value for LINEA chain USDT is verified as correct.
The decimal value of
6
for the USDT token on the LINEA chain is consistently set across the codebase, confirming its correctness.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the USDT token decimal value for the LINEA chain. # Test: Check if the decimal value for USDT on the LINEA chain is consistently set to 6 across the codebase. rg --type ts 'decimals.*\[CHAINS.LINEA.id\]: 6'Length of output: 49
Script:
#!/bin/bash # Broaden the search to find any mention of 'LINEA' and 'USDT' to verify the decimal value. # Search for any mentions of 'LINEA' and 'USDT' in the codebase. rg --type ts 'LINEA' -A 5 rg --type ts 'USDT' -A 5Length of output: 307193
Deploying sanguine-fe with Cloudflare Pages
|
Deploying sanguine with Cloudflare Pages
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2995 +/- ##
===================================================
+ Coverage 25.24881% 25.25057% +0.00176%
===================================================
Files 780 780
Lines 56771 56771
Branches 82 82
===================================================
+ Hits 14334 14335 +1
Misses 40958 40958
+ Partials 1479 1478 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
The pull request adds support for Linea USDT in the bridgeable tokens list by updating the USDT
token definition in the bridgeable.ts
file.
- Updated
packages/synapse-interface/constants/tokens/bridgeable.ts
to include Linea chain ID and address for USDT. - Added Linea-specific address to the
addresses
property of theUSDT
token. - Included Linea-specific decimal value in the
decimals
property of theUSDT
token. - Ensured consistency with existing token definitions for multi-chain support.
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Summary by CodeRabbit
5c61b61: synapse-interface preview link