-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fear(widget): Adds Linea #2983
fear(widget): Adds Linea #2983
Conversation
WalkthroughThe recent updates enhance the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This pull request adds support for the Linea blockchain to the Synapse widget, expanding its compatibility with different blockchain ecosystems.
- Added Linea chain configuration in
/packages/widget/src/constants/chains.ts
with network details and RPC URLs - Updated
BRIDGE_MAP
in/packages/widget/src/constants/bridgeMap.ts
to include Linea token information (USDC, USDT, ETH, WETH) - Modified
/packages/widget/src/constants/bridgeable.ts
to add USDC and ETH token addresses for Linea - Upgraded @synapsecns/widget package from version 0.1.0 to 0.6.3 in both Next.js and React example projects
5 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
primary: 'https://rpc.linea.build', | ||
fallback: 'https://linea.blockpi.network/v1/rpc/public', | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Consider using HTTPS for both primary and fallback RPC URLs for enhanced security
Deploying sanguine-fe with Cloudflare Pages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (5)
- packages/widget/examples/with-next/package.json (1 hunks)
- packages/widget/examples/with-react/package.json (1 hunks)
- packages/widget/src/constants/bridgeMap.ts (5 hunks)
- packages/widget/src/constants/bridgeable.ts (4 hunks)
- packages/widget/src/constants/chains.ts (2 hunks)
Additional comments not posted (17)
packages/widget/examples/with-next/package.json (1)
12-12
: Verify the impact of upgrading@synapsecns/widget
to^0.6.3
.The version upgrade from
^0.1.0
to^0.6.3
may include new features, bug fixes, or breaking changes. Ensure that the application is tested thoroughly with this new version to avoid any unexpected issues.packages/widget/examples/with-react/package.json (1)
6-6
: Verify the impact of upgrading@synapsecns/widget
to0.6.3
.The version upgrade from
0.1.0
to0.6.3
may include new features, bug fixes, or breaking changes. Ensure that the application is tested thoroughly with this new version to avoid any unexpected issues.packages/widget/src/constants/chains.ts (2)
446-465
: LGTM! Ensure the newLINEA
constant is correctly integrated.The addition of the
LINEA
constant follows the pattern of other chain constants and seems well-structured.
489-489
: Verify the integration of theLINEA
constant in the codebase.Ensure that the new
LINEA
constant is correctly integrated and does not introduce any issues.Verification successful
The
LINEA
constant is correctly integrated in the codebase.The
LINEA
constant is consistently referenced across multiple files, indicating proper integration. Here are some key locations:
packages/widget/src/constants/chains.ts
packages/widget/src/constants/bridgeable.ts
packages/sdk-router/src/constants/chainIds.ts
packages/synapse-constants/constants/tokens/bridgeable.ts
packages/synapse-constants/constants/chains/master.ts
packages/synapse-constants/constants/chains/index.ts
packages/sdk-router/src/constants/medianTime.ts
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the integration of the LINEA constant in the codebase. # Test: Search for the usage of the LINEA constant. Expect: Correct integration without issues. rg --type typescript -A 5 $'LINEA'Length of output: 68
Script:
#!/bin/bash # Description: Verify the integration of the LINEA constant in the codebase. # Test: Search for the usage of the LINEA constant in TypeScript files. rg 'LINEA' --glob '*.ts' -A 5Length of output: 8367
packages/widget/src/constants/bridgeable.ts (4)
439-439
: Added support for LINEA blockchain for USDC token.The address
0x176211869cA2b568f2A7D4EE941E073a821EE1ff
and decimals6
for the LINEA blockchain have been correctly added.
456-456
: Confirmed decimal value for LINEA blockchain for USDC token.The decimal value
6
for the LINEA blockchain has been correctly added and is consistent with other entries.
807-807
: Added support for LINEA blockchain for ETH token.The address
ZeroAddress
and decimals18
for the LINEA blockchain have been correctly added.
819-819
: Confirmed decimal value for LINEA blockchain for ETH token.The decimal value
18
for the LINEA blockchain has been correctly added and is consistent with other entries.packages/widget/src/constants/bridgeMap.ts (9)
1797-1803
: Verify the address and consistency for the newUSDC
entry.The new entry for
USDC
appears correct, but please verify the address0x176211869cA2b568f2A7D4EE941E073a821EE1ff
and ensure consistency with other entries.
1804-1810
: Verify the address and consistency for the newUSDT
entry.The new entry for
USDT
appears correct, but please verify the address0xA219439258ca9da29E9Cc4cE5596924745e12B93
and ensure consistency with other entries.
1811-1817
: Verify the address and consistency for the newETH
entry.The new entry for
ETH
appears correct, but please verify the address0xEeeeeEeeeEeEeeEeEeEeeEEEeeeeEeeeeeeeEEeE
and ensure consistency with other entries.
1818-1824
: Verify the address and consistency for the newWETH
entry.The new entry for
WETH
appears correct, but please verify the address0xe5D7C2a44FfDDf6b295A15c148167daaAf5Cf34f
and ensure consistency with other entries.
Line range hint
1844-1848
:
Verify the changes and consistency for the updatedWETH
entry.The updated entry for
WETH
appears correct, but please verify the changes to theorigin
field and ensure consistency with other entries.
1861-1862
: Verify the changes and consistency for the updatedETH
entry.The updated entry for
ETH
appears correct, but please verify the changes to theorigin
anddestination
fields and ensure consistency with other entries.
1871-1872
: Verify the changes and consistency for the updatednETH
entry.The updated entry for
nETH
appears correct, but please verify the changes to theorigin
field and ensure consistency with other entries.
1901-1906
: Verify the address and consistency for the newUSDT
entry.The new entry for
USDT
appears correct, but please verify the address0xf55BEC9cafDbE8730f096Aa55dad6D22d44099Df
and ensure consistency with other entries.
1881-1886
: Verify the address and consistency for the newUSDC
entry.The new entry for
USDC
appears correct, but please verify the address0x06eFdBFf2a14a7c8E15944D1F4A48F9F95F663A4
and ensure consistency with other entries.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2983 +/- ##
===================================================
+ Coverage 25.70802% 25.71722% +0.00919%
===================================================
Files 771 771
Lines 55613 55562 -51
Branches 80 82 +2
===================================================
- Hits 14297 14289 -8
+ Misses 39830 39788 -42
+ Partials 1486 1485 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Bundle ReportChanges will decrease total bundle size by 7.17MB ⬇️
|
Summary by CodeRabbit
New Features
@synapsecns/widget
dependency to a newer version, enhancing overall functionality.Bug Fixes